lhotari commented on code in PR #23577:
URL: https://github.com/apache/pulsar/pull/23577#discussion_r1855749826
##########
pulsar-client/src/main/java/org/apache/pulsar/client/util/NameUtil.java:
##########
@@ -21,7 +21,7 @@
import java.util.UUID;
import org.apache.commons.codec.digest.DigestUtils;
-public class ConsumerName {
+public class NameUtil {
public static String generateRandomName() {
return DigestUtils.sha1Hex(UUID.randomUUID().toString()).substring(0,
5);
}
Review Comment:
why was this class renamed? This is not a generic method that we'd like to
reuse more broadly. The original method `generateRandomName` is not even
describing the name properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
