lhotari commented on code in PR #23642:
URL: https://github.com/apache/pulsar/pull/23642#discussion_r1858721612
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/TopicLookupBase.java:
##########
@@ -342,6 +343,22 @@ public static CompletableFuture<ByteBuf>
lookupTopicAsync(PulsarService pulsarSe
return lookupfuture;
}
+ /**
+ * Check if a internal client will get a null lookup result.
+ */
+ private static void printWarnLogIfLookupResUnexpected(TopicName topic,
LookupData lookupData,
+ PulsarService
pulsar) {
+ if (!pulsar.getBrokerService().isSystemTopic(topic)) {
+ return;
+ }
+ boolean tlsEnabled = pulsar.getConfig().isBrokerClientTlsEnabled();
+ if (!tlsEnabled && StringUtils.isBlank(lookupData.getBrokerUrl())) {
+ log.warn("[{}] Unexpected lookup result {}", topic.toString(),
lookupData);
+ } else if (tlsEnabled &&
StringUtils.isBlank(lookupData.getBrokerUrlTls())) {
+ log.warn("[{}] Unexpected lookup result {}", topic.toString(),
lookupData);
Review Comment:
It would be useful to improve the log message to be explicit about why it's
unexpected by adding "brokerUrlTls is required when TLS is enabled."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
