lhotari commented on code in PR #23612:
URL: https://github.com/apache/pulsar/pull/23612#discussion_r1858806808


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGeneratorWithNoUnsafeTest.java:
##########


Review Comment:
   This isn't sufficient alone to address the problem of testing this change. 
   It's necessary to move this to a new test group which runs tests 
individually (`-DtestReuseFork=false -DtestForkCount=1`) so that every test 
class in this group starts with a clean JVM. 
   I could push the changes to this PR to get this addressed.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to