Nictec commented on code in PR #228:
URL:
https://github.com/apache/pulsar-client-python/pull/228#discussion_r1866591383
##########
src/client.cc:
##########
@@ -41,19 +42,39 @@ Consumer Client_subscribe(Client& client, const
std::string& topic, const std::s
[&](SubscribeCallback callback) { client.subscribeAsync(topic,
subscriptionName, conf, callback); });
}
+void Client_subscribeAsync(Client& client, const std::string& topic, const
std::string& subscriptionName,
+ const ConsumerConfiguration& conf, SubscribeCallback
callback) {
+ py::gil_scoped_release release;
+ client.subscribeAsync(topic, subscriptionName, conf, callback);
+}
+
Consumer Client_subscribe_topics(Client& client, const
std::vector<std::string>& topics,
const std::string& subscriptionName, const
ConsumerConfiguration& conf) {
return waitForAsyncValue<Consumer>(
[&](SubscribeCallback callback) { client.subscribeAsync(topics,
subscriptionName, conf, callback); });
}
+void Client_subscribe_topicsAsync(Client& client, const
std::vector<std::string>& topics, const std::string& subscriptionName, const
ConsumerConfiguration& conf, SubscribeCallback callback){
+ client.subscribeAsync(topics, subscriptionName, conf, [callback](Result
result, pulsar::Consumer consumer){
Review Comment:
Nothing, I just forgot to remove my TODO. The following commit fixes the
schema problems:
[https://github.com/Nictec/pulsar-client-python/commit/656a287da2794ee4760baf9a09d53352f8f8520b](https://github.com/Nictec/pulsar-client-python/commit/656a287da2794ee4760baf9a09d53352f8f8520b)
Ill remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
