dao-jun commented on code in PR #23686:
URL: https://github.com/apache/pulsar/pull/23686#discussion_r1872789456


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/cache/impl/MetadataCacheImpl.java:
##########
@@ -58,6 +61,7 @@ public class MetadataCacheImpl<T> implements 
MetadataCache<T>, Consumer<Notifica
     private final MetadataStore store;
     private final MetadataStoreExtended storeExtended;
     private final MetadataSerde<T> serde;
+    private final ScheduledExecutorService backoffExecutor = 
Executors.newSingleThreadScheduledExecutor();

Review Comment:
   It' better not use `Executors....` to new an Executor.
   BTW, can we reuse the existing scheduler?  Such as 
`AbstractMetadataStore.executor`, maybe we can increase it's thread num to more.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to