lhotari commented on PR #23688:
URL: https://github.com/apache/pulsar/pull/23688#issuecomment-2524542596

   > @hangc0276 Good catch! There seems to also be a problem with sizeLimit. 
It's an integer and could overflow. Instead of `ByteUnitToIntegerConverter`, 
the `ByteUnitToLongConverter` should be used.
   
   Addressed in #23689. It also covers changes to `retentionTimeInSec` overflow 
fix made in this PR. @hangc0276 please review #23689 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to