hrzzzz commented on code in PR #23693:
URL: https://github.com/apache/pulsar/pull/23693#discussion_r1875542319
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java:
##########
@@ -517,6 +517,13 @@ public void flushAndClean() {
pendingIndividualAcks.clear();
Review Comment:
1. We can use the `flushAndClean` method, but it performs some additional
unnecessary operations. Therefore, I added the `clean` method to simply reset
the `acknowledgmentsGroupingTracker`. If you think this is not appropriate, I
can reuse the flushAndClean method.
2. The `flushAndClean` method internally removes elements from
`pendingIndividualBatchIndexAcks`, so there is no issue with this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
