lhotari commented on code in PR #23719:
URL: https://github.com/apache/pulsar/pull/23719#discussion_r1881832102
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -1449,7 +1449,9 @@ The max allowed delay for delayed delivery (in
milliseconds). If the broker rece
@FieldContext(
category = CATEGORY_SERVER,
dynamic = true,
- doc = "The position that replication task start at, it can be set
to earliest or latest (default).")
+ doc = "The position that replication task start at, it can be set
to earliest or latest (default). Note: do"
+ + " not use \"MessageId.earliest\" because its value is
\"-1:-1:-1\", which does not equals"
+ + " \"earliest\"")
Review Comment:
Why would someone set a String value in the config to "MessageId.earliest"?
The notes about MessageId.earliest is simply confusing. It's better not to
add the note at all.
```suggestion
doc = "The position that replication task start at, it can be
set to earliest or latest (default).")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
