ericsyh commented on code in PR #559:
URL: https://github.com/apache/pulsar-helm-chart/pull/559#discussion_r1884041245


##########
charts/pulsar/values.yaml:
##########
@@ -228,29 +228,48 @@ tls:
     keySize: 4096
     keyAlgorithm: RSA
     keyEncoding: PKCS8
+    caSecretName:
   # settings for generating certs for proxy
   proxy:
     enabled: false
     cert_name: tls-proxy
     createCert: true  # set to false if you want to use an existing certificate
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for broker
   broker:
     enabled: false
     cert_name: tls-broker
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for bookies
   bookie:
     enabled: false
     cert_name: tls-bookie
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for zookeeper
   zookeeper:
     enabled: false
     cert_name: tls-zookeeper
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for recovery
   autorecovery:
     cert_name: tls-recovery
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for toolset
   toolset:
     cert_name: tls-toolset
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true

Review Comment:
   this comment is fixed by 
https://github.com/apache/pulsar-helm-chart/pull/559/commits/736dbf8b7523cfa161601a554a9777b31b468ca3
 commit 



##########
charts/pulsar/values.yaml:
##########
@@ -228,29 +228,48 @@ tls:
     keySize: 4096
     keyAlgorithm: RSA
     keyEncoding: PKCS8
+    caSecretName:
   # settings for generating certs for proxy
   proxy:
     enabled: false
     cert_name: tls-proxy
     createCert: true  # set to false if you want to use an existing certificate
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for broker
   broker:
     enabled: false
     cert_name: tls-broker
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for bookies
   bookie:
     enabled: false
     cert_name: tls-bookie
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for zookeeper
   zookeeper:
     enabled: false
     cert_name: tls-zookeeper
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for recovery
   autorecovery:
     cert_name: tls-recovery
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true

Review Comment:
   this comment is fixed by 
https://github.com/apache/pulsar-helm-chart/pull/559/commits/736dbf8b7523cfa161601a554a9777b31b468ca3
 commit 



##########
charts/pulsar/values.yaml:
##########
@@ -228,29 +228,48 @@ tls:
     keySize: 4096
     keyAlgorithm: RSA
     keyEncoding: PKCS8
+    caSecretName:
   # settings for generating certs for proxy
   proxy:
     enabled: false
     cert_name: tls-proxy
     createCert: true  # set to false if you want to use an existing certificate
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for broker
   broker:
     enabled: false
     cert_name: tls-broker
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for bookies
   bookie:
     enabled: false
     cert_name: tls-bookie
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true

Review Comment:
   this comment is fixed by 
https://github.com/apache/pulsar-helm-chart/pull/559/commits/736dbf8b7523cfa161601a554a9777b31b468ca3
 commit 



##########
charts/pulsar/values.yaml:
##########
@@ -228,29 +228,48 @@ tls:
     keySize: 4096
     keyAlgorithm: RSA
     keyEncoding: PKCS8
+    caSecretName:
   # settings for generating certs for proxy
   proxy:
     enabled: false
     cert_name: tls-proxy
     createCert: true  # set to false if you want to use an existing certificate
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for broker
   broker:
     enabled: false
     cert_name: tls-broker
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for bookies
   bookie:
     enabled: false
     cert_name: tls-bookie
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true
   # settings for generating certs for zookeeper
   zookeeper:
     enabled: false
     cert_name: tls-zookeeper
+    # specify name of secret contain certificate if using pre-generated 
certificate
+    certSecretName:
+    untrustedCa: true

Review Comment:
   this comment is fixed by 
https://github.com/apache/pulsar-helm-chart/pull/559/commits/736dbf8b7523cfa161601a554a9777b31b468ca3
 commit 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to