lhotari commented on code in PR #21105:
URL: https://github.com/apache/pulsar/pull/21105#discussion_r1893535797
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2954,53 +2971,99 @@ private static List<StringProperty>
buildStringPropertiesMap(Map<String, String>
return stringProperties;
}
- private List<MLDataFormats.MessageRange>
buildIndividualDeletedMessageRanges() {
+ @VisibleForTesting
+ List<MLDataFormats.MessageRange> buildIndividualDeletedMessageRanges() {
Review Comment:
Instead of adding "VisibleForTesting" annotation here, please extract this
logic to a separate class which is tested separately. There's a lot of
complexity here and this would be very hard to maintain in the future in this
form. Smaller classes and smaller methods are a general preference in
maintainable code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
