hrzzzz opened a new pull request, #23764:
URL: https://github.com/apache/pulsar/pull/23764

   ### Motivation
   
   https://github.com/apache/pulsar/pull/21367 introduced the `migrated` field 
in `localPolicies` to indicate whether the topics under a namespace have been 
migrated in the blue-green cluster migration feature.
   
   In https://github.com/apache/pulsar/pull/9598, it is specified that when 
updating the field content of `localPolicies`, a new object needs to be created 
instead of updating the original object.
   
   After the addition of the `migrated` field in 
https://github.com/apache/pulsar/pull/21367, there has been no synchronization 
of modifications in other places that update `localPolicies`. This could lead 
to the loss of the `migrated` content during other operations on 
`localPolicies`, such as setting the `namespaceAntiAffinityGroup`, etc.
   
   ### Modifications
   
   1. Synchronize the `migrated` content in the places where `localPolicies` 
are updated
   2. When updating the `migrated` field of `localPolicies`, do not modify the 
original object
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
   - Added test in: 
org.apache.pulsar.broker.admin.NamespacesTest#testMigratedInfoIsNotLostDuringOtherLocalPoliciesUpdate
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: https://github.com/hrzzzz/pulsar/pull/13
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to