lhotari commented on code in PR #23751:
URL: https://github.com/apache/pulsar/pull/23751#discussion_r1893697855
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -250,6 +252,26 @@ public class ServerCnx extends PulsarHandler implements
TransportCnx {
private final long connectionLivenessCheckTimeoutMillis;
+ private static final LongAdder totalPendingBytes = new LongAdder();
+ private static volatile Gauge pendingPublishBufferUsage;
Review Comment:
It's not a great idea to add static fields. This should be handled in the
BrokerService, I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]