lhotari commented on code in PR #23762:
URL: https://github.com/apache/pulsar/pull/23762#discussion_r1894230492


##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/sinks/KinesisSinkTester.java:
##########
@@ -128,8 +130,9 @@ public void stopServiceContainer() {
 
     @Override
     protected LocalStackContainer createSinkService(PulsarCluster cluster) {
-        return new 
LocalStackContainer(DockerImageName.parse("localstack/localstack:1.0.4"))
-                .withServices(LocalStackContainer.Service.KINESIS);
+        return new 
LocalStackContainer(DockerImageName.parse("localstack/localstack:4.0.3"))

Review Comment:
   We could, but I don't think that it's relevant in this PR. There won't be a 
need to upgrade this on-the-fly since this isn't an application library 
dependency or even a test library dependency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to