yyj8 commented on PR #23770: URL: https://github.com/apache/pulsar/pull/23770#issuecomment-2559532882
> > > @nodece would it be possible to cover #23769 feature too? That enables subscription replication for all subscriptions at the broker level if I understand it correctly. Could you work together with @yyj8 to cover that? > > > > > > #23769 aims to overwrite the subscription replication state from the consumer, which is different from this PIP. Actually, I also need an overwrite feature, and then the users use the admin API to manage the subscription replication. > > The downstream users sometimes enable/disable the subscription replication on the consumer, this lead to the namespace or topic level is ignored. > > We can also merge #23769 to this PIP. What's your opinion? @lhotari @yyj8 > > @nodece @yyj8 Please work together to combine both cases since they are both valuable and useful. I think it would make sense to combine the work in a single PIP to ensure that we achieve consistency across the changes. > > > @nodece would it be possible to cover #23769 feature too? That enables subscription replication for all subscriptions at the broker level if I understand it correctly. Could you work together with @yyj8 to cover that? > > > > > > #23769 aims to overwrite the subscription replication state from the consumer, which is different from this PIP. Actually, I also need an overwrite feature, and then the users use the admin API to manage the subscription replication. > > The downstream users sometimes enable/disable the subscription replication on the consumer, this lead to the namespace or topic level is ignored. > > We can also merge #23769 to this PIP. What's your opinion? @lhotari @yyj8 > > @nodece @yyj8 Please work together to combine both cases since they are both valuable and useful. I think it would make sense to combine the work in a single PIP to ensure that we achieve consistency across the changes. This is a great idea and suggestion. Can we consider a strategy that divides into three dimensions: cluster dimension, namespace dimension, and topic dimension. (1)PR https://github.com/apache/pulsar/pull/23769 As a cluster dimension strategy, merge it into this PIP https://github.com/apache/pulsar/pull/23770; (2)PR https://github.com/apache/pulsar/pull/23769 add the function of dynamically configuring parameter `replicateAllSubscriptionState` values through the command `bin/pulse admin brokers update-dynamic-config --config replicateAllSubscriptionState --value true/false` @nodece @lhotari Can you see if this method is feasible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
