erobot opened a new pull request, #468:
URL: https://github.com/apache/pulsar-client-cpp/pull/468
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see
*[Guideline - Pulsar PR Naming
Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
### Motivation
<!-- Explain here the context, and why you're making that change. What is
the problem you're trying to solve. -->
Fix some compiler warnings in public headers when using with -Wextra. These
warnings prevent projects using -Wextra -Werror to use pulsar client without
modifications.
### Modifications
<!-- Describe the modifications you've done. -->
1. Modified public headers to fix compiler warnings
2. Add compile options "-Wextra -Wno-unused-parameter" to compile examples
to help find similar issues
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change can be verified as follows:
- Add compile options "-Wextra -Wno-unused-parameter" to compile examples to
help find similar issues
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
Only the compiler warnings have been fixed, and there is no change in
functionality.
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
