This is an automated email from the ASF dual-hosted git repository.
xyz pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git
The following commit(s) were added to refs/heads/main by this push:
new bdf6854 Fix some compiler warnings in public headers (#468)
bdf6854 is described below
commit bdf685492f90b0d079e8885ce33b4402839d0495
Author: erobot <[email protected]>
AuthorDate: Thu Dec 26 13:14:50 2024 +0800
Fix some compiler warnings in public headers (#468)
### Motivation
Fix some compiler warnings in public headers when using with -Wextra. These
warnings prevent projects using -Wextra -Werror to use pulsar client without
modifications.
### Modifications
1. Modified public headers to fix compiler warnings
2. Add compile options "-Wextra -Wno-unused-parameter" to compile examples
to help find similar issues
---
examples/CMakeLists.txt | 1 +
include/pulsar/BrokerConsumerStats.h | 2 +-
include/pulsar/Message.h | 2 +-
include/pulsar/c/client_configuration.h | 4 ++--
lib/BrokerConsumerStats.cc | 2 +-
lib/Message.cc | 2 +-
lib/c/c_ClientConfiguration.cc | 6 ++----
7 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/examples/CMakeLists.txt b/examples/CMakeLists.txt
index d54c228..6ffb407 100644
--- a/examples/CMakeLists.txt
+++ b/examples/CMakeLists.txt
@@ -19,6 +19,7 @@
if (NOT MSVC)
set(CMAKE_C_FLAGS " -std=c99 ${CMAKE_C_FLAGS}")
+ add_compile_options(-Wextra -Wno-unused-parameter)
endif()
set(SAMPLE_ASYNC_PRODUCER_SOURCES
diff --git a/include/pulsar/BrokerConsumerStats.h
b/include/pulsar/BrokerConsumerStats.h
index e179e4b..37eb454 100644
--- a/include/pulsar/BrokerConsumerStats.h
+++ b/include/pulsar/BrokerConsumerStats.h
@@ -73,7 +73,7 @@ class PULSAR_PUBLIC BrokerConsumerStats {
virtual const std::string getConnectedSince() const;
/** Returns Whether this subscription is Exclusive or Shared or Failover */
- virtual const ConsumerType getType() const;
+ virtual ConsumerType getType() const;
/** Returns the rate of messages expired on this subscription. msg/s */
virtual double getMsgRateExpired() const;
diff --git a/include/pulsar/Message.h b/include/pulsar/Message.h
index c8c18fa..2e78e98 100644
--- a/include/pulsar/Message.h
+++ b/include/pulsar/Message.h
@@ -176,7 +176,7 @@ class PULSAR_PUBLIC Message {
/**
* Get the redelivery count for this message
*/
- const int getRedeliveryCount() const;
+ int getRedeliveryCount() const;
/**
* Check if schema version exists
diff --git a/include/pulsar/c/client_configuration.h
b/include/pulsar/c/client_configuration.h
index 6c4f3df..9e15453 100644
--- a/include/pulsar/c/client_configuration.h
+++ b/include/pulsar/c/client_configuration.h
@@ -195,13 +195,13 @@ PULSAR_PUBLIC const char
*pulsar_client_configuration_get_listener_name(pulsar_c
PULSAR_PUBLIC void pulsar_client_configuration_set_partitions_update_interval(
pulsar_client_configuration_t *conf, const unsigned int intervalInSeconds);
-PULSAR_PUBLIC const unsigned int
pulsar_client_configuration_get_partitions_update_interval(
+PULSAR_PUBLIC unsigned int
pulsar_client_configuration_get_partitions_update_interval(
pulsar_client_configuration_t *conf);
/*
* Get the stats interval set in the client.
*/
-PULSAR_PUBLIC const unsigned int
pulsar_client_configuration_get_stats_interval_in_seconds(
+PULSAR_PUBLIC unsigned int
pulsar_client_configuration_get_stats_interval_in_seconds(
pulsar_client_configuration_t *conf);
PULSAR_PUBLIC void
pulsar_client_configuration_set_keep_alive_interval_in_seconds(
diff --git a/lib/BrokerConsumerStats.cc b/lib/BrokerConsumerStats.cc
index a403772..b2eaa8f 100644
--- a/lib/BrokerConsumerStats.cc
+++ b/lib/BrokerConsumerStats.cc
@@ -63,7 +63,7 @@ const std::string BrokerConsumerStats::getAddress() const {
return impl_->getAdd
const std::string BrokerConsumerStats::getConnectedSince() const { return
impl_->getConnectedSince(); }
-const ConsumerType BrokerConsumerStats::getType() const { return
impl_->getType(); }
+ConsumerType BrokerConsumerStats::getType() const { return impl_->getType(); }
double BrokerConsumerStats::getMsgRateExpired() const { return
impl_->getMsgRateExpired(); }
diff --git a/lib/Message.cc b/lib/Message.cc
index 06fa5db..2a6e8a3 100644
--- a/lib/Message.cc
+++ b/lib/Message.cc
@@ -184,7 +184,7 @@ const std::string& Message::getTopicName() const {
return impl_->getTopicName();
}
-const int Message::getRedeliveryCount() const {
+int Message::getRedeliveryCount() const {
if (!impl_) {
return 0;
}
diff --git a/lib/c/c_ClientConfiguration.cc b/lib/c/c_ClientConfiguration.cc
index 9f7b6b3..483c74e 100644
--- a/lib/c/c_ClientConfiguration.cc
+++ b/lib/c/c_ClientConfiguration.cc
@@ -173,8 +173,7 @@ void
pulsar_client_configuration_set_stats_interval_in_seconds(pulsar_client_con
conf->conf.setStatsIntervalInSeconds(interval);
}
-const unsigned int pulsar_client_configuration_get_stats_interval_in_seconds(
- pulsar_client_configuration_t *conf) {
+unsigned int
pulsar_client_configuration_get_stats_interval_in_seconds(pulsar_client_configuration_t
*conf) {
return conf->conf.getStatsIntervalInSeconds();
}
@@ -204,8 +203,7 @@ void
pulsar_client_configuration_set_partitions_update_interval(pulsar_client_co
conf->conf.setPartititionsUpdateInterval(intervalInSeconds);
}
-const unsigned int pulsar_client_configuration_get_partitions_update_interval(
- pulsar_client_configuration_t *conf) {
+unsigned int
pulsar_client_configuration_get_partitions_update_interval(pulsar_client_configuration_t
*conf) {
return conf->conf.getPartitionsUpdateInterval();
}
