liudezhi2098 commented on code in PR #23798:
URL: https://github.com/apache/pulsar/pull/23798#discussion_r1900375330
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarChannelInitializer.java:
##########
@@ -69,26 +71,17 @@ public PulsarChannelInitializer(ClientConfigurationData
conf, Supplier<ClientCnx
this.socks5ProxyAddress = conf.getSocks5ProxyAddress();
this.socks5ProxyUsername = conf.getSocks5ProxyUsername();
this.socks5ProxyPassword = conf.getSocks5ProxyPassword();
-
+ this.conf = conf;
Review Comment:
fix spotbugs
Medium: new
org.apache.pulsar.client.impl.PulsarChannelInitializer(ClientConfigurationData,
Supplier, ScheduledExecutorService) may expose internal representation by
storing an externally mutable object into PulsarChannelInitializer.conf
[org.apache.pulsar.client.impl.PulsarChannelInitializer] At
PulsarChannelInitializer.java:[line 74] EI_EXPOSE_REP2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
