lhotari commented on PR #22792:
URL: https://github.com/apache/pulsar/pull/22792#issuecomment-2579474717
@dao-jun To speed up the review, I pushed the changes for adding a
configuration parameter
`managedLedgerCursorResetLedgerCloseTimestampMaxClockSkewMillis` and logic to
handle it. That was something that I was concerned about. Do the changes look
ok to you?
```java
@FieldContext(
category = CATEGORY_STORAGE_ML,
dynamic = true,
doc = "When resetting a subscription by timestamp, the broker
will use the"
+ " ledger closing timestamp metadata to determine the
range of ledgers"
+ " to search for the message where the subscription
position is reset to. "
+ " Since by default, the search condition is based on
the message publish time provided by the "
+ " client at the publish time, there will be some clock
skew between the ledger closing timestamp "
+ " metadata and the publish time."
+ " This configuration is used to set the max clock skew
between the ledger closing"
+ " timestamp and the message publish time for finding
the range of ledgers to open for searching."
+ " The default value is 60000 milliseconds (60
seconds). When set to -1, the broker will not"
+ " use the ledger closing timestamp metadata to
determine the range of ledgers to search for the"
+ " message."
)
private int
managedLedgerCursorResetLedgerCloseTimestampMaxClockSkewMillis = 60000;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
