lhotari commented on PR #23811: URL: https://github.com/apache/pulsar/pull/23811#issuecomment-2581217946
> I pass the start time of the result as a parameter rather than making it an inherent attribute of the result. This is because I don't want the result to become an inherent variable of `AsyncFuncRequest`. If it were an inherent variable, the result would be exposed, triggering the EI_EXPOSE_REP warning. That makes the code worse in my opinion. I'd recommend adding a definition to the `src/main/resources/findbugsExclude.xml` file to ignore the `EI_EXPOSE_REP` SpotBugs/FindBugs check for the particular method. We do that already for many other locations. This is the file where you can add a new entry: https://github.com/apache/pulsar/blob/master/pulsar-functions/instance/src/main/resources/findbugsExclude.xml . ```xml <Match> <Class name="org.apache.pulsar.functions.instance.JavaInstance$AsyncFuncRequest"/> <Method name="getResult"/> <Bug pattern="EI_EXPOSE_REP"/> </Match> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
