poorbarcode commented on code in PR #23839: URL: https://github.com/apache/pulsar/pull/23839#discussion_r1912597571
########## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java: ########## @@ -220,6 +221,23 @@ private void receiveSubscriptionUpdated(ReplicatedSubscriptionsUpdate update) { private void startNewSnapshot() { cleanupTimedOutSnapshots(); + if (lastCompletedSnapshotStartTime == 0 && !pendingSnapshots.isEmpty()) { Review Comment: Since you skipped the snapshot here, how can `lastCompletedSnapshotStartTime` be set to a non-null value> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org