lhotari commented on code in PR #23844:
URL: https://github.com/apache/pulsar/pull/23844#discussion_r1913076248
##########
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java:
##########
@@ -70,6 +71,7 @@ public static class ExtractedFunctionDetails {
static final Integer MAX_PENDING_ASYNC_REQUESTS_DEFAULT = 1000;
static final Boolean FORWARD_SOURCE_MESSAGE_PROPERTY_DEFAULT =
Boolean.TRUE;
+ private static final List<String> VALID_LOG_LEVELS = Arrays.asList("INFO",
"DEBUG", "WARN", "ERROR");
Review Comment:
there are more valid levels in Log4J 2:
https://logging.apache.org/log4j/2.x/manual/customloglevels.html . I'm not sure
if others are relevant, but perhaps it would make sense to allow any valid
Log4J log level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
