poorbarcode commented on code in PR #23853:
URL: https://github.com/apache/pulsar/pull/23853#discussion_r1919489564
##########
pulsar-client/src/test/java/org/apache/pulsar/client/impl/ProducerImplTest.java:
##########
@@ -74,35 +66,4 @@ public void testPopulateMessageSchema() {
assertTrue(producer.populateMessageSchema(msg, null));
verify(msg).setSchemaState(MessageImpl.SchemaState.Ready);
}
-
- @Test
- public void testClearPendingMessageWhenCloseAsync() {
- PulsarClientImpl client = mock(PulsarClientImpl.class);
- Mockito.doReturn(1L).when(client).newProducerId();
- ClientConfigurationData clientConf = new ClientConfigurationData();
- clientConf.setStatsIntervalSeconds(-1);
- Mockito.doReturn(clientConf).when(client).getConfiguration();
- Mockito.doReturn(new
InstrumentProvider(null)).when(client).instrumentProvider();
- ConnectionPool connectionPool = mock(ConnectionPool.class);
- Mockito.doReturn(1).when(connectionPool).genRandomKeyToSelectCon();
- Mockito.doReturn(connectionPool).when(client).getCnxPool();
- HashedWheelTimer timer = mock(HashedWheelTimer.class);
- Mockito.doReturn(null).when(timer).newTimeout(Mockito.any(),
Mockito.anyLong(), Mockito.any());
- Mockito.doReturn(timer).when(client).timer();
- ProducerConfigurationData producerConf = new
ProducerConfigurationData();
- producerConf.setSendTimeoutMs(-1);
- ProducerImpl<?> producer = Mockito.spy(new ProducerImpl<>(client,
"topicName", producerConf, null, 0, null, null, Optional.empty()));
-
- // make sure throw exception when send request to broker
- ClientCnx clientCnx = mock(ClientCnx.class);
- CompletableFuture<ProducerResponse> tCompletableFuture = new
CompletableFuture<>();
- tCompletableFuture.completeExceptionally(new
PulsarClientException("error"));
- when(clientCnx.sendRequestWithId(Mockito.any(),
Mockito.anyLong())).thenReturn(tCompletableFuture);
- Mockito.doReturn(clientCnx).when(producer).cnx();
-
- // run closeAsync and verify
- CompletableFuture<Void> voidCompletableFuture = producer.closeAsync();
- verify(producer).closeAndClearPendingMessages();
- }
Review Comment:
I described it in the section Modification
> - move fails all pending sends when producer.connection is null to
reconnect successfully, which was introduced by
https://github.com/apache/pulsar/pull/23761
> - Remove the test that https://github.com/apache/pulsar/pull/23761
added, which has been covered by the new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
