This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-4.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 5350ff7c094cb60d7fa8c5d9442f6f74d27081d6 Author: jiangpengcheng <[email protected]> AuthorDate: Fri Jan 24 12:10:59 2025 +0800 [improve][fn] Set default tenant and namespace for ListFunctions cmd (#23881) (cherry picked from commit 66d1bb0d734f12d758b0f0e9e3c0b42543508f8d) --- .../java/org/apache/pulsar/admin/cli/CmdFunctionsTest.java | 13 +++++++++++++ .../main/java/org/apache/pulsar/admin/cli/CmdFunctions.java | 10 ++++++++++ 2 files changed, 23 insertions(+) diff --git a/pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/CmdFunctionsTest.java b/pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/CmdFunctionsTest.java index d3087b7fc87..5cac07502b4 100644 --- a/pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/CmdFunctionsTest.java +++ b/pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/CmdFunctionsTest.java @@ -631,6 +631,19 @@ public class CmdFunctionsTest { verify(functions, times(1)).getFunctions(eq(TENANT), eq(NAMESPACE)); } + @Test + public void testListFunctionsWithDefaultValue() throws Exception { + cmd.run(new String[] { + "list", + }); + + ListFunctions lister = cmd.getLister(); + assertEquals("public", lister.getTenant()); + assertEquals("default", lister.getNamespace()); + + verify(functions, times(1)).getFunctions(eq("public"), eq("default")); + } + @Test public void testStateGetter() throws Exception { String key = TEST_NAME + "-key"; diff --git a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java index 4c7e058af6d..a1b8d26ef18 100644 --- a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java +++ b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java @@ -105,6 +105,16 @@ public class CmdFunctions extends CmdBase { @Option(names = "--namespace", description = "The namespace of a Pulsar Function") protected String namespace; + + @Override + public void processArguments() { + if (tenant == null) { + tenant = PUBLIC_TENANT; + } + if (namespace == null) { + namespace = DEFAULT_NAMESPACE; + } + } } /**
