sijie commented on a change in pull request #4935: [Transaction][Buffer] handle 
command `EndTxnOnPartitiion`
URL: https://github.com/apache/pulsar/pull/4935#discussion_r313769923
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
 ##########
 @@ -1533,4 +1586,49 @@ public boolean isBatchMessageCompatibleVersion() {
     public String getClientVersion() {
         return clientVersion;
     }
+
+    /**
+     * The transaction marker controller controls the commit marker or the 
abort marker publish to the specified topic.
+     * If it is a commit marker, we need to wait for the position it committed 
at the topic.
+     */
+    final static class TxnMarkerController implements Topic.PublishContext {
 
 Review comment:
   don't you need to implement `getProducerName` to make sure exactly-once when 
publish markers?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to