sijie commented on a change in pull request #4935: [Transaction][Buffer] handle
command `EndTxnOnPartitiion`
URL: https://github.com/apache/pulsar/pull/4935#discussion_r313770650
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java
##########
@@ -345,6 +351,11 @@ public void removeProducer(Producer producer) {
return delete(false, true, false);
}
+ @Override
+ protected TransactionBufferProvider getProvider() throws IOException {
+ return
TransactionBufferProvider.newProvider(transactionBufferProvider);
Review comment:
you already know it is InMemTransactionBuffer. why can't you just construct
an in-memory transaction buffer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
