lhotari commented on PR #23915: URL: https://github.com/apache/pulsar/pull/23915#issuecomment-2631032504
> I updated the address, but there are some errors in the tests.Please take a look. @lhotari What you should do is to ensure that tests pass with your changes. If not, it's either a flaky test or your changes break the tests. For example this test breaks: https://github.com/guan46/pulsar/actions/runs/13072194671/job/36541465274?pr=3#step:11:2705 . If you think that a test failure could be a flaky test, you can ["re-run failed jobs" in the GitHub Actions UI](https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/re-running-workflows-and-jobs#re-running-failed-jobs-in-a-workflow). For actual test failures caused by your changes, you should run them in IDE and debug the reasons why they fail with your changes. It would be pointless if a contributor makes PRs without handling this step on their own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
