shibd commented on code in PR #23928:
URL: https://github.com/apache/pulsar/pull/23928#discussion_r1943902157
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java:
##########
@@ -624,7 +624,12 @@ &&
pulsar().getConfig().isCreateTopicToRemoteClusterForReplication()) {
asyncResponse.resume(Response.noContent().build());
})
.exceptionally(ex -> {
- log.error("[{}] Failed to create partitioned topic {}",
clientAppId(), topicName, ex);
+ if (AdminResource.isConflictException(ex)) {
+ log.warn("[{}] Failed to create partitioned topic {}:
{}", clientAppId(), topicName,
Review Comment:
When encountering a resource NotFound or Exist exception, maybe just
printing an info level log is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
