TakaHiR07 commented on PR #21552: URL: https://github.com/apache/pulsar/pull/21552#issuecomment-2639028631
This problem has not been fixed and I hope to continue the review of this pr. Firstly, I think the data inconsistent issue of asyncOpenLedgerNoRecovery is not exist. - Because we can read the compactedLedger until ledger become Closed. There is no write client and read client exist at the same time. Just as the following code show, we close the ledger success and then do reader.acknowledgeCumulativeAsync, then COMPACTED_TOPIC_LEDGER_PROPERTY would be changed to the specific ledgerId, and then we asyncOpenLedgerNoRecovery the compactedLedger and the compactedTopicContext would be created. - If the write client not finish, we can not create compactedTopicContext and can not create the read client. https://github.com/apache/pulsar/blob/8a40b30cf47a91ec02d931e6371d02409ba5951e/pulsar-broker/src/main/java/org/apache/pulsar/compaction/AbstractTwoPhaseCompactor.java#L184-L212 Second, we only register listener for compactedLedger, the listener number is not huge. @codelipenghui @zymap @codelipenghui @yebai1105 @coderzc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
