lhotari commented on code in PR #23958:
URL: https://github.com/apache/pulsar/pull/23958#discussion_r1950756275
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/PendingReadsManager.java:
##########
@@ -211,73 +211,95 @@ private FindPendingReadOutcome
findPendingRead(PendingReadKey key, ConcurrentMap
private class PendingRead {
final PendingReadKey key;
final ConcurrentMap<PendingReadKey, PendingRead> ledgerCache;
- final List<ReadEntriesCallbackWithContext> callbacks = new
ArrayList<>(1);
- boolean completed = false;
+ final List<ReadEntriesCallbackWithContext> listeners = new
ArrayList<>(1);
+ PendingReadState state = PendingReadState.INITIALISED;
+
+ enum PendingReadState {
+ INITIALISED,
+ ATTACHED,
+ COMPLETED
+ }
public PendingRead(PendingReadKey key,
ConcurrentMap<PendingReadKey, PendingRead>
ledgerCache) {
this.key = key;
this.ledgerCache = ledgerCache;
}
- public void attach(CompletableFuture<List<EntryImpl>> handle) {
+ public synchronized void attach(CompletableFuture<List<EntryImpl>>
handle) {
+ if (state != PendingReadState.INITIALISED) {
+ // this shouldn't ever happen. this is here to prevent misuse
in future changes
+ throw new IllegalStateException("Unexpected state " + state +
" for PendingRead for key " + key);
+ }
+ state = PendingReadState.ATTACHED;
Review Comment:
Removing synchronization isn't the scope of this PR. Synchronization itself
isn't a problem here. The deadlock was caused by calling callbacks while
holding the synchronization lock. That is the main purpose of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
