dao-jun commented on code in PR #23943:
URL: https://github.com/apache/pulsar/pull/23943#discussion_r1957692817
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageWithBatchIndexLevelTest.java:
##########
@@ -137,6 +138,67 @@ public void testBatchMessageAck() {
});
}
+ @DataProvider
+ public Object[][] enabledBatchSend() {
+ return new Object[][] {
+ {false},
+ {true}
+ };
+ }
+
+ @Test(dataProvider = "enabledBatchSend")
+ @SneakyThrows
+ public void testBatchMessageNAck(boolean enabledBatchSend) {
+ final String topicName =
BrokerTestUtil.newUniqueName("persistent://prop/ns-abc/tp");
+ final String subscriptionName = "s1";
+ ConsumerImpl<byte[]> consumer = (ConsumerImpl<byte[]>)
pulsarClient.newConsumer().topic(topicName)
+ .subscriptionName(subscriptionName)
+ .receiverQueueSize(21)
+ .subscriptionType(SubscriptionType.Shared)
+ .enableBatchIndexAcknowledgment(true)
+ .negativeAckRedeliveryDelay(100, TimeUnit.MILLISECONDS)
+ .subscribe();
+ Producer<byte[]> producer = pulsarClient.newProducer().topic(topicName)
+ .batchingMaxMessages(20)
+ .batchingMaxPublishDelay(1, TimeUnit.HOURS)
+ .enableBatching(enabledBatchSend)
+ .create();
+ final PersistentTopic topic = (PersistentTopic)
pulsar.getBrokerService().getTopicReference(topicName).get();
+ final AbstractPersistentDispatcherMultipleConsumers dispatcher =
+ (AbstractPersistentDispatcherMultipleConsumers)
topic.getSubscription(subscriptionName).getDispatcher();
+
+ // Send messages: 20 * 2.
+ for (int i = 0; i < 40; i++) {
+ byte[] message = ("batch-message-" + i).getBytes();
+ if (i == 19 || i == 39) {
+ producer.newMessage().value(message).send();
+ } else {
+ producer.newMessage().value(message).sendAsync();
+ }
+ }
+ Awaitility.await().untilAsserted(() -> {
+ if (enabledBatchSend) {
+ assertEquals(consumer.numMessagesInQueue(), 40);
+ } else {
+ assertEquals(consumer.numMessagesInQueue(), 21);
+ }
+ });
+
+ // Negative ack and verify result/
+ Message<byte[]> receive1 = consumer.receive();
+ consumer.pause();
Review Comment:
`pause` is for stop receiving msgs from broker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
