blankensteiner commented on code in PR #253: URL: https://github.com/apache/pulsar-dotpulsar/pull/253#discussion_r1958073549
########## src/DotPulsar/DotPulsar.csproj: ########## @@ -24,6 +24,7 @@ </PropertyGroup> <ItemGroup> + <PackageReference Include="Apache.Avro" Version="1.12.0" /> Review Comment: Just to clarify. Some Pulsar clients bring in a lot of functionality and therefore a lot of packages. Sometimes with different, and possibly problematic, licenses and we must also remember that licensing might change (we have seen that multiple times). Besides licensing there is the constant issue of reliability, support, target frameworks, documentation, and security in bringing in packages. When it comes to serialization the issue is often that multiple packages are doing the same thing, but they might not be compatible. This means that one JSON package might serialize differently than another and thereby not be compatible, even though you should think so because it's all JSON, right? I don't know if it is the same thing with Avro, since I have never used it. My focus is on letting the user choose whether they want Avro or not and if they do, they should be able to use whatever package they want. Let's see if we can make that happen :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
