BewareMyPower commented on code in PR #1338:
URL: https://github.com/apache/pulsar-client-go/pull/1338#discussion_r1972748593
##########
pulsar/producer_partition.go:
##########
@@ -846,6 +848,21 @@ type pendingItem struct {
flushCallback func(err error)
}
+func (i *pendingItem) done(err error) {
Review Comment:
Could you avoid changing the method's position? I see you deleted the
original `done` method below and added it here, while there is actually a small
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
