BewareMyPower commented on code in PR #1338:
URL: https://github.com/apache/pulsar-client-go/pull/1338#discussion_r1972883544
##########
pulsar/producer_partition.go:
##########
@@ -846,6 +848,21 @@ type pendingItem struct {
flushCallback func(err error)
}
+func (i *pendingItem) done(err error) {
Review Comment:
Let's not discuss about the IDE issues. Some questions:
1. Is there any CI that prevents a new method inserted between the
`pendingItem` struct and its `done` method?
2. If not and a new struct is inserted between these, you're going to push
another PR to make `done` close to `pendingItem` so that your IDE could be
satisfied?
Please don't pollute the commit diff by moving a whole method to another
position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
