lhotari commented on PR #24045: URL: https://github.com/apache/pulsar/pull/24045#issuecomment-2697980589
> I've been learning about Pulsar recently. I learn it by reading PRs. If I find any issues, I'll also submit PRs myself. I'm not an AI. @lhotari Thanks for your clarification. Some Apache projects have been receiving PRs which are AI generated with human assistance and I wanted to check that. I hope you understand that's the reason why there's a pushback for anonymous contributors. There's 2 concerns why projects avoid anonymous contributions: the trend of AI training by creating PRs and security. We also want to avoid security incidents where a contributor gains trust and later pushes malicious PRs that get accepted into code bases. The xz/liblzma backdoor incident is a sobering reminder of how anonymous trusted contributors can compromise critical infrastructure. We can put security concerns aside. Since your profile was anonymous it was a red flag to me mainly related to the "AI training" scams that have been hitting OSS repositories. A real person opens the PR, but requested by a AI training company and the review feedback is fed back to train AI and to make follow up changes assisted by AI. I see that you have added your name to your profile, which is very useful in avoiding such suspicions. For this specific PR, it would be helpful if you could explain in more detail what performance improvements you expect from removing this call, perhaps with some measurements or profiling data that shows the impact. When you provide this clarification, reviewers won't have to spend their limited time in finding out these details. For microbenchmarks we have [the microbench module in Pulsar](https://github.com/apache/pulsar/tree/master/microbench) where new JMH microbenchmarks can be added. I'm not saying that it's necessary in this case if there's another way to explain what "improve performance" means and what the expected impact of the change is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
