crossoverJie commented on code in PR #1343:
URL: https://github.com/apache/pulsar-client-go/pull/1343#discussion_r1984388572
##########
pulsar/internal/connection.go:
##########
@@ -534,7 +524,7 @@ func (c *connection) writeCommand(cmd *pb.BaseCommand) {
}
func (c *connection) receivedCommand(cmd *pb.BaseCommand, headersAndPayload
Buffer) {
- c.incomingCmdCh <- &incomingCmd{cmd, headersAndPayload}
+ c.internalReceivedCommand(cmd, headersAndPayload)
Review Comment:
The `internalReceivedCommand` function is only used here, so it is
recommended to merge `receivedCommand` and `internalReceivedCommand` into a
single function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
