lhotari commented on code in PR #24063: URL: https://github.com/apache/pulsar/pull/24063#discussion_r1984639045
########## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ########## @@ -429,6 +429,9 @@ public void operationComplete(ManagedLedgerInfo mlInfo, Stat stat) { log.debug("[{}] Opened ledger {}: {}", name, id, BKException.getMessage(rc)); } if (rc == BKException.Code.OK) { + if (State.Terminated.equals(state)) { Review Comment: I don't think that `STATE_UPDATER.get` is needed. It makes no difference when reading volatile variables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org