lhotari commented on code in PR #24071:
URL: https://github.com/apache/pulsar/pull/24071#discussion_r1995124410
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java:
##########
@@ -1183,6 +1188,23 @@ public void testDeadLetterTopicWithProducerBuilder()
throws Exception {
} while (totalInDeadLetter < sendMessages);
assertTrue(messageContent.isEmpty());
+ // check the retry topic producer enable batch
+ List<ConsumerImpl<byte[]>> consumers =
((MultiTopicsConsumerImpl<byte[]>) consumer).getConsumers();
+ for (ConsumerImpl<byte[]> consumerImpl : consumers) {
+ Producer<byte[]> retryProducer =
consumerImpl.getRetryLetterProducer();
+ Producer<byte[]> deadLetterProducer =
consumerImpl.getDeadLetterProducer();
+ // there are two type of consumers in MultiTopicsConsumerImpl when
enableRetry is true
+ // 1. consumer subscribe to original topic
+ // 2. consumer subscribe to retry topic
+ if
(consumerImpl.getTopic().endsWith(RetryMessageUtil.RETRY_GROUP_TOPIC_SUFFIX)) {
+ assertTrue(((ProducerImpl<byte[]>)
retryProducer).isBatchMessagingEnabled());
+ assertTrue(((ProducerImpl<byte[]>)
deadLetterProducer).isBatchMessagingEnabled());
+ } else {
+ assertTrue(((ProducerImpl<byte[]>)
retryProducer).isBatchMessagingEnabled());
Review Comment:
sorry, makes sense now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
