(pulsar) 06/09: [fix][broker] http metric endpoint get compaction latency stats always be 0 (#24067)

[lhotari]

This is an automated email from the ASF dual-hosted git repository.

lhotari pushed a commit to branch branch-4.0
in repository https://gitbox.apache.org/repos/asf/pulsar.git

commit 97f7c13ac89c94003d39c9e255252827eb969c5f
Author: Hao Zhang <zhangh...@cmss.chinamobile.com>
AuthorDate: Fri Mar 14 16:01:07 2025 +0800

    [fix][broker] http metric endpoint get compaction latency stats always be 0 
(#24067)
    
    Co-authored-by: 张浩 <zhangha...@100.me>
    (cherry picked from commit 2eff40f7390b6d08f37a53ee909aead57c4ae5c4)
---
 .../org/apache/pulsar/compaction/CompactionRecord.java     |  1 +
 .../apache/pulsar/compaction/CompactorMXBeanImplTest.java  | 14 ++++++++++++++
 2 files changed, 15 insertions(+)

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactionRecord.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactionRecord.java
index cea005d51b8..6488b92f5e8 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactionRecord.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactionRecord.java
@@ -111,6 +111,7 @@ public class CompactionRecord {
     }
 
     public StatsBuckets getCompactionLatencyStats() {
+        writeLatencyStats.refresh();
         return writeLatencyStats;
     }
 
diff --git 
a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactorMXBeanImplTest.java
 
b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactorMXBeanImplTest.java
index 73e7430bd2d..f78e54c8b22 100644
--- 
a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactorMXBeanImplTest.java
+++ 
b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactorMXBeanImplTest.java
@@ -20,6 +20,7 @@ package org.apache.pulsar.compaction;
 
 import static org.testng.Assert.assertEquals;
 import static org.testng.Assert.assertTrue;
+import org.apache.bookkeeper.mledger.util.StatsBuckets;
 import org.testng.annotations.Test;
 
 import java.util.concurrent.TimeUnit;
@@ -61,4 +62,17 @@ public class CompactorMXBeanImplTest {
         assertTrue(compaction.getCompactionLatencyBuckets()[0] > 0L);
     }
 
+    @Test
+    public void testCompactionLatencyStatsAddAll() {
+        CompactorMXBeanImpl mxBean = new CompactorMXBeanImpl();
+        String topic = "topic2";
+        mxBean.addCompactionStartOp(topic);
+        CompactionRecord compaction = 
mxBean.getCompactionRecordForTopic(topic).get();
+        StatsBuckets compactionLatencyBuckets = new 
StatsBuckets(CompactionRecord.WRITE_LATENCY_BUCKETS_USEC);
+        mxBean.addCompactionLatencyOp(topic, 10, TimeUnit.NANOSECONDS);
+        
compactionLatencyBuckets.addAll(compaction.getCompactionLatencyStats());
+        compactionLatencyBuckets.refresh();
+        assertTrue(compactionLatencyBuckets.getBuckets()[0] > 0L);
+    }
+
 }