shibd commented on code in PR #24097:
URL: https://github.com/apache/pulsar/pull/24097#discussion_r2013582472
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java:
##########
@@ -137,10 +137,18 @@ public CompletableFuture<Void>
deleteTopicPoliciesAsync(TopicName topicName) {
return CompletableFuture.completedFuture(null);
}
TopicName changeEvents =
NamespaceEventsSystemTopicFactory.getEventsTopicName(topicName.getNamespaceObject());
- return
pulsarService.getNamespaceService().checkTopicExists(changeEvents).thenCompose(topicExistsInfo
-> {
+ CompletableFuture<Boolean> changeEventTopicExists =
pulsarService.getPulsarResources().getTopicResources()
+
.persistentTopicExists(changeEvents).thenCompose(nonPartitionedExists -> {
+ if (!nonPartitionedExists) {
+ return pulsarService.getPulsarResources().getTopicResources()
Review Comment:
Why do we need to double-check partition-0 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
