3pacccccc commented on code in PR #24141:
URL: https://github.com/apache/pulsar/pull/24141#discussion_r2018847363
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/DisabledCreateTopicToRemoteClusterForReplicationTest.java:
##########
@@ -108,7 +108,10 @@ public void testCreatePartitionedTopicWithNsReplication()
throws Exception {
admin2.topics().createPartitionedTopic(tp, 1);
Consumer<String> consumer2 =
client2.newConsumer(Schema.STRING).topic(tp).isAckReceiptEnabled(true)
.subscriptionName("s1").subscribe();
- assertEquals(consumer2.receive(10, TimeUnit.SECONDS).getValue(),
msgValue);
+ Awaitility.await().atMost(30, TimeUnit.SECONDS).untilAsserted(() -> {
+ assertEquals(consumer2.receive().getValue(), msgValue);
+ });
Review Comment:
> @3pacccccc Since you are contributing more, it's worth adding a name to
your profile. Eventually [Apache
ICLA](https://www.apache.org/licenses/contributor-agreements.html) would have
to be signed for contributions and it's better to not remain anonymous even
before that step.
thank you for your noticing, I'll complete my profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
