heesung-sn commented on code in PR #24156:
URL: https://github.com/apache/pulsar/pull/24156#discussion_r2033565606
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -1505,7 +1502,21 @@ private void doHealthCheckBrokerAsyncWithRetries(String
brokerId, int retry, Com
}
}
- private synchronized void doCleanup(String broker, boolean gracefully) {
+ private void tryWaitForOverrides(List<CompletableFuture<Void>>
overrideFutures, boolean force) {
Review Comment:
Thank you for sharing this class. I think this simple array list is fine for
this case as requests are added in a synchronized manner by the single load
manager executor thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
