lhotari commented on code in PR #24178:
URL: https://github.com/apache/pulsar/pull/24178#discussion_r2043773372
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java:
##########
@@ -199,6 +201,10 @@ public ProducerImpl(PulsarClientImpl client, String topic,
ProducerConfiguration
this.userProvidedProducerName = StringUtils.isNotBlank(producerName);
this.partitionIndex = partitionIndex;
this.pendingMessages = createPendingMessagesQueue();
+ // Replication need be stuck when a message can not be replicated due
to failed schema registration. Otherwise,
+ // it may cause an out-of-order issue, and it may lead to a messages
lost issue if users enabled deduplication
+ // on the remote side.
+ this.needStuckIfSchemaIncompatible = conf.isReplProducer();
Review Comment:
I asked Claude AI for suggestion. `preservePublishOrderOnSchemaFailure` or
``preservePublishOrderOnSchemaFailureByPausingSending` are suggestions based on
that. I'm not sure if that's accurate.
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java:
##########
@@ -199,6 +201,10 @@ public ProducerImpl(PulsarClientImpl client, String topic,
ProducerConfiguration
this.userProvidedProducerName = StringUtils.isNotBlank(producerName);
this.partitionIndex = partitionIndex;
this.pendingMessages = createPendingMessagesQueue();
+ // Replication need be stuck when a message can not be replicated due
to failed schema registration. Otherwise,
+ // it may cause an out-of-order issue, and it may lead to a messages
lost issue if users enabled deduplication
+ // on the remote side.
+ this.needStuckIfSchemaIncompatible = conf.isReplProducer();
Review Comment:
I asked Claude AI for suggestion. `preservePublishOrderOnSchemaFailure` or
`preservePublishOrderOnSchemaFailureByPausingSending` are suggestions based on
that. I'm not sure if that's accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
