liangyepianzhou commented on code in PR #24028: URL: https://github.com/apache/pulsar/pull/24028#discussion_r2044373938
########## pip/pip-410-pending-publish-buffer-usage-metrics.md: ########## @@ -0,0 +1,47 @@ +# PIP-410: Introduce pending publish buffer usage metrics + +# Background knowledge + +Since https://github.com/apache/pulsar/pull/6178, we introduced broker side backpressure to prevent the broker from +being overwhelmed by the producers. + +But we don't have a way to monitor the pending publish buffer usage. This PIP proposes to introduce 2 new metrics to +complete the monitoring of the pending publish buffer usage. + +# Motivation + +Add metrics to monitor the pending publish buffer usage. + +# Goals + +## In Scope + +Broker level: +- Introduce a new metric `pulsar.broker.publish.buffer.usage` to monitor the current pending publish buffer usage. +- Introduce a new metric `pulsar.broker.publish.buffer.max.usage` to monitor the max pending publish buffer usage. Review Comment: IMO, the data source of the indicator should be provided. For example, `pulsar.broker.publish.buffer.usage` is the current usage of the publish buffer of the monitored broker, while `pulsar.broker.publish.buffer.max.usage` is a fixed configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
