poorbarcode opened a new pull request, #24211:
URL: https://github.com/apache/pulsar/pull/24211

   ### Motivation
   
   See also https://github.com/apache/pulsar/pull/24200#issuecomment-2827963819
   
   > Sorry, I did not completely review #24200. I assumed that you added new 
tests in `OneWayReplicatorUsingGlobalZKTest` and 
`OneWayReplicatorUsingGlobalPartitionedTest`, which makes #24200 meaningful. 
But the exact changes are that you just copied tests from the super class into 
the child classes. I will revert this PR, because it did nothing.
   
   `OneWayReplicatorTest` -- child -> `OneWayReplicatorUsingGlobalZKTest` -- 
child -> `OneWayReplicatorUsingGlobalPartitionedTest`
   
   They shared some tests, and other tests in 
`OneWayReplicatorUsingGlobalZKTest` and 
`OneWayReplicatorUsingGlobalPartitionedTest` have not be implemented completely.
   
   https://github.com/apache/pulsar/pull/24200 makes the three test classes 
independent, and copies the shared tests into 
`OneWayReplicatorUsingGlobalZKTest` and 
`OneWayReplicatorUsingGlobalPartitionedTest`, which is meaningless.
   
   ### Modifications
   - Revert #24200
   - I will finish the tests that has modifier `@Test(enabled = false)` one by 
one in the future, they are needed
   
   
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: x
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to