lhotari commented on code in PR #509:
URL: https://github.com/apache/pulsar-helm-chart/pull/509#discussion_r2063431392
##########
charts/pulsar/values.yaml:
##########
@@ -273,12 +273,28 @@ tls:
auth:
authentication:
enabled: false
- provider: "jwt"
Review Comment:
Since many users don't read release notes, it's useful to add validation to
prevent users from upgrading unless they remove deprecated config values.
Add a template called `_values_validation.tpl` and add validation with
something like
```
{{- if (and .Values.auth.authentication.enabled (not (empty
.Values.auth.authentication.provider))) }}
{{- fail "ERROR: Setting auth.authentication.provider is no longer
supported. For details, see the migration guide in README.md." }}
{{- end }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
