nodece commented on code in PR #24225:
URL: https://github.com/apache/pulsar/pull/24225#discussion_r2072293154
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java:
##########
@@ -596,12 +598,32 @@ protected void
internalCreatePartitionedTopic(AsyncResponse asyncResponse, int n
}
})
.thenCompose(__ -> checkTopicExistsAsync(topicName))
- .thenAccept(exists -> {
- if (exists) {
- log.warn("[{}] Failed to create already existing topic
{}", clientAppId(), topicName);
- throw new RestException(Status.CONFLICT, "This topic
already exists");
+ .thenAccept(topicExistsInfo -> {
+ try {
+ if (topicExistsInfo.isExists()) {
+ if
(topicExistsInfo.getTopicType().equals(TopicType.NON_PARTITIONED)
+ ||
(topicExistsInfo.getTopicType().equals(TopicType.PARTITIONED)
+ && !createLocalTopicOnly)) {
Review Comment:
@poorbarcode When a partitioned topic will be synchronized to the remote
cluster, we allow the remote cluster includes this metadata. The local and
remote clusters may be shared a global zk.
createLocalTopicOnly=true means this creation request comes from a cluster,
not user client, we can continue to create the partitioned topic if the
metadata is existing on the remote cluster.
The pulsar has been covered this changed by existing test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
