liangyepianzhou commented on PR #24293: URL: https://github.com/apache/pulsar/pull/24293#issuecomment-2876455036
> In addition, this PR should never be a "fix". > > Regarding the unused public methods, currently I think we can just remove them directly without marking the old methods as `@Deprecated`. > > I started a discussion long days ago: https://lists.apache.org/thread/v4bswc3byqtvpl3h4cjpvzm8sbsy0wq9 > > We should not waste much time keeping compatibility for any public method because a public method is added too casually (that might be also why there is such a PIP: #24290) @AuroraTwinkle @BewareMyPower Thank you for the valuable feedback! 🙏 The original intention of this PR was indeed to address a specific issue I identified during code review (https://github.com/apache/pulsar/pull/24225 regarding asynchronous methods directly calling synchronously named methods), but your perspectives have helped me realize the need to consider standardization from a higher-level approach. There's one point I completely agree with: systematic standardization should take precedence over localized fixes. For similar issues in the future, we should file GitHub issues to track them and address them collectively after establishing clear guidelines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
