lhotari commented on issue #23079: URL: https://github.com/apache/pulsar/issues/23079#issuecomment-2898055484
> Most of the Checkstyle violations are related to ImportOrder, No spaces between import statements, LineLength, whitespace issues, and some naming conventions for final fields and class names. After fixing these violations, will it cause any problems in other branches? ImportOrder and styling can be easily addressed in IntelliJ. Cherry-picking to `branch-4.0` is easy and it would be sufficient to address `branch-3.0` for the maintenance branches. > some naming conventions for final fields and class names We might just revisit the convention so that this isn't applied to test classes. There's not much value in enforcing such conventions in test classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
