poorbarcode commented on code in PR #24359:
URL: https://github.com/apache/pulsar/pull/24359#discussion_r2115367542


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/InflightReadsLimiter.java:
##########
@@ -177,8 +177,10 @@ private synchronized Optional<Handle> internalAcquire(long 
permits, Consumer<Han
             return Optional.of(new Handle(maxReadsInFlightSize, 
handle.creationTime, true));
         } else {
             if (queuedHandles.size() >= maxReadsInFlightAcquireQueueSize) {
-                log.warn("Failed to queue handle for acquiring permits: {}, 
creationTime: {}, remainingBytes:{}",
-                        permits, handle.creationTime, remainingBytes);
+                log.warn("Failed to queue handle for acquiring permits: {}, 
creationTime: {}, remainingBytes:{},"
+                    + " maxReadsInFlightAcquireQueueSize:{}, 
pending-queue-size: {}, please increase broker"
+                    + " config 
managedLedgerMaxReadsInFlightPermitsAcquireQueueSize",

Review Comment:
   Addressed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to