nodece commented on code in PR #24376:
URL: https://github.com/apache/pulsar/pull/24376#discussion_r2127904518
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java:
##########
@@ -596,6 +597,8 @@ private CompletableFuture<Long>
individualAckNormal(CommandAck ack, Map<String,
if (checkCanRemovePendingAcksAndHandle(ackOwnerConsumer,
position, msgId)) {
addAndGetUnAckedMsgs(ackOwnerConsumer, -(int) ackedCount);
updateBlockedConsumerOnUnackedMsgs(ackOwnerConsumer);
+ } else if (Subscription.isCumulativeAckMode(subType)) {
Review Comment:
> I got your concerns and the else branch will be removed in WIP.
You can cleanup in WIP.
> It's not conformed to the name of the method if we return true for
exclusive model. So may I leave a else branch here for now?
I think we can do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
